[11u] RFR: 8233164: C2 fails with assert(phase->C->get_alias_index(t) == phase->C->get_alias_index(t_adr)) failed: correct memory chain

[Doerr, Martin]

Hi Götz,

thanks for the review!

Best regards,
Martin


From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Sent: Montag, 21. Dezember 2020 14:49
To: Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>; jdk-updates-dev at openjdk.java.net
Cc: Langer, Christoph <christoph.langer at sap.com>
Subject: RE: [11u] RFR: 8233164: C2 fails with assert(phase->C->get_alias_index(t) == phase->C->get_alias_index(t_adr)) failed: correct memory chain

Hi Martin,

Looks good and resolve was trivial (I guess ��)

Best regards,
  Goetz.

From: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Sent: Monday, December 21, 2020 12:52 PM
To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net<mailto:hotspot-compiler-dev at openjdk.java.net>>; jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Cc: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
Subject: [11u] RFR: 8233164: C2 fails with assert(phase->C->get_alias_index(t) == phase->C->get_alias_index(t_adr)) failed: correct memory chain

Hi,

JDK-8233164 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change applies almost cleanly. I only had to integrate the following hunk manually due to unrelated context changes:
--- arraycopynode.cpp
+++ arraycopynode.cpp
@@ -574,8 +573,8 @@

   Node* src = in(ArrayCopyNode::Src);
   Node* dest = in(ArrayCopyNode::Dest);
-  const TypePtr* atp_src = get_address_type(phase, src);
-  const TypePtr* atp_dest = get_address_type(phase, dest);
+  const TypePtr* atp_src = get_address_type(phase, _src_type, src);
+  const TypePtr* atp_dest = get_address_type(phase, _dest_type, dest);

   Node *in_mem = in(TypeFunc::Memory);
   if (!in_mem->is_MergeMem()) {

Bug:
https://bugs.openjdk.java.net/browse/JDK-8233164

Original change:
https://hg.openjdk.java.net/jdk/jdk14/rev/be9033a248f7

11u backport:
http://cr.openjdk.java.net/~mdoerr/8233164_C2_11u/webrev.00/

Please review.

Best regards,
Martin