[11u] RFR: 8234742: Improve handshake logging

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Dec 30 10:14:03 UTC 2020


Hi Martin,

I had a look at your change. I also compared it with the
original version that has both involved changes.

You might want to adapt the comment:
-            // hence it is skipped in handshake_process_by_vmthread.
+            // hence it is skipped in handshake_try_process_by_vmthread.
I don't need a new webrev.

Looks good.

Best regards,
  Goetz.



From: Doerr, Martin <martin.doerr at sap.com>
Sent: Wednesday, December 23, 2020 4:11 PM
To: hotspot-runtime-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net
Cc: Langer, Christoph <christoph.langer at sap.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: [11u] RFR: 8234742: Improve handshake logging

Hi,

JDK-8234742 is backported to 11.0.11-oracle. I'd like to backport it for parity.
Change doesn't apply cleanly at all, mainly because JDK-8244340 was integrated before this one which was in the wrong order.
(Failing hunks are listed here: http://cr.openjdk.java.net/~mdoerr/8234742_handshake_11u/8234742_handshake_failing_hunks.txt)
So my 11u backport is supposed to reflect the state of both changes integrated.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8234742

Original change:
https://hg.openjdk.java.net/jdk/jdk/rev/c2ce3849c62f

Other change which was backported in the wrong order and from which I've taken small parts:
https://hg.openjdk.java.net/jdk/jdk/rev/67a435ce2dc2

11u backport:
http://cr.openjdk.java.net/~mdoerr/8234742_handshake_11u/webrev.00/

Please review.

Best regards,
Martin



More information about the jdk-updates-dev mailing list