[11u] RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

[Langer, Christoph]

Hi Alex,

I've approved all items.

You wrote in some comments that you had jcheck issues due to different author naming in the original git changes vs. mercurial.

Did you use git hg-export [1]? Are you aware of it? I usually use it for every backport and it seemed to work fine for me every time so far. (Although I heard of issues with it with larger commit messages or something like that.)

Best regards
Christoph

https://wiki.openjdk.java.net/display/SKARA/git-hg-export


> -----Original Message-----
> From: Alex Kashchenko <akashche at redhat.com>
> Sent: Dienstag, 29. Dezember 2020 20:34
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8256818: SSLSocket that is never bound or connected
> leaks socket resources
> 
> On 12/22/20, Langer, Christoph <christoph.langer at sap.com> wrote:
> > Hi Alex,
> >
> > thanks for doing this backport. It looks good to me. As you mention, it
> > should be pushed together with these follow up items which are all part of
> > 11.0.11-oracle as well:
> > https://bugs.openjdk.java.net/browse/JDK-8257670
> > https://bugs.openjdk.java.net/browse/JDK-8257884
> > https://bugs.openjdk.java.net/browse/JDK-8257997
> 
> Thanks for the review! I've flagged all 4 issues for approval.
> 
> >
> > [...]
> >
> 
> --
> -Alex