[11u] RFR 8238591: CTW: Split applications/ctw/modules/jdk_localedata.java

[Hohensee, Paul]

I learn something new every day. :) Reviewed.

Paul

On 2/12/20, 7:45 AM, "Aleksey Shipilev" <shade at redhat.com> wrote:

    Hi Paul,
    
    On 2/12/20 4:36 PM, Hohensee, Paul wrote:
    > jdk_localdata_2.java is a new file, but the webrev seems to show it as a copy of jdk_localdata.java. Revise the webrev?
    
    jdk_localedata_2.java is a copy, and this is intentional! Mercurial tools are bad at showing this.
    
    If you go to jdk/jdk, then you would see "new file" has the history prior 8238591:
    
     $ hg log test/hotspot/jtreg/applications/ctw/modules/jdk_localedata_2.java -f
    
     changeset:   57976:b585d773ea0f
     user:        shade
     date:        Mon Feb 10 06:18:46 2020 +0100
     summary:     8238591: CTW: Split applications/ctw/modules/jdk_localedata.java
    
     changeset:   54386:00fc7ba000b4
     user:        iignatyev
     date:        Tue Apr 02 13:39:22 2019 -0700
     summary:     8221870: use driver to run CtwRunner in applications/ctw tests
    
     ...
    
    ...or see the original webrev:
      https://cr.openjdk.java.net/~shade/8238591/webrev.01/
    
    ...or see the metadata:
     "parents: test/hotspot/jtreg/applications/ctw/modules/jdk_localedata.java at 00fc7ba000b4"
    
    https://hg.openjdk.java.net/jdk/jdk/file/b585d773ea0f/test/hotspot/jtreg/applications/ctw/modules/jdk_localedata_2.java
    
    > On 2/12/20, 2:54 AM, "jdk-updates-dev on behalf of Aleksey Shipilev" <jdk-updates-dev-bounces at openjdk.java.net on behalf of shade at redhat.com> wrote:
    > 
    >     Original bug:
    >       https://bugs.openjdk.java.net/browse/JDK-8238591
    >       https://hg.openjdk.java.net/jdk/jdk/rev/b585d773ea0f
    >     
    >     Unfortunately, there are minor context differences: @module java.base/jdk.internal.access is not
    >     applicable due to missing JDK-8211122 (already rejected for 11u). So I had to drop that line from
    >     the new copy.
    >     
    >     11u webrev:
    >       http://cr.openjdk.java.net/~shade/8238591/webrev.11u.01/
    
    
    -- 
    Thanks,
    -Aleksey