[11u] RFR (XS): 8239466: Loss of precision in counter decay calculation in 11u backport of JDK-8237375

[Langer, Christoph]

Thanks for the reviews, Volker and Martin ��

> -----Original Message-----
> From: Volker Simonis <volker.simonis at gmail.com>
> Sent: Mittwoch, 19. Februar 2020 20:43
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net; Doerr, Martin
> <martin.doerr at sap.com>
> Subject: Re: [11u] RFR (XS): 8239466: Loss of precision in counter decay
> calculation in 11u backport of JDK-8237375
> 
> On Wed, Feb 19, 2020 at 4:26 PM Langer, Christoph
> <christoph.langer at sap.com> wrote:
> >
> > Hi,
> >
> >
> >
> > I have backported JDK-8237375 [0] [1] to jdk11u (11.0.7) with the change
> [2].
> >
> >
> >
> > Unfortunately, the backport contains a flaw that leads to a loss of precision
> when checking whether a counter decay is needed in method
> is_decay_needed() which in turn might yield the same test failures that we
> wanted to fix. Please review the correction:
> >
> 
> What a pity :(
> Sorry that I missed that in the first review.
> 
> >
> >
> http://cr.openjdk.java.net/~clanger/webrevs/8239466.11u/src/hotspot/shar
> e/runtime/compilationPolicy.cpp.frames.html
> >
> 
> Looks good now!
> 
> Thanks for fixing,
> Volker
> 
> 
> >
> > Thanks
> >
> > Christoph
> >
> >
> >
> > [0] https://bugs.openjdk.java.net/browse/JDK-8237375
> >
> > [1] https://hg.openjdk.java.net/jdk/jdk/rev/2a0e2304e68b
> >
> > [2] https://hg.openjdk.java.net/jdk-updates/jdk11u-
> dev/rev/695c552952bc
> >
> >