[11u] RFR: 8223638: Replace wildcard address with loopback or local host in tests - part 6
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Wed Jan 8 09:04:49 UTC 2020
Hi Martin,
thanks for reviewing!
Best regards,
Goetz.
> -----Original Message-----
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Donnerstag, 2. Januar 2020 14:33
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8223638: Replace wildcard address with loopback or
> local host in tests - part 6
>
> Hi Götz,
>
> Integrating the TestHttpServer.java part from JDK-8223145 makes sense to
> me.
> Looks good.
>
> Best regards,
> Martin
>
>
> > -----Original Message-----
> > From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Sent: Donnerstag, 2. Januar 2020 12:28
> > To: Doerr, Martin <martin.doerr at sap.com>; jdk-updates-
> > dev at openjdk.java.net
> > Subject: RE: [11u] RFR: 8223638: Replace wildcard address with loopback or
> > local host in tests - part 6
> >
> > Hi,
> >
> > unfortunately I had to do another change to get this working.
> >
> > java/net/URL/PerConnectionProxy.java calls a new constructor from
> > TestHttpServer.java that was added in "8223145: Replace wildcard address
> > with loopback or local host in tests - part 1".
> > 8223145 does not apply well. Also I don't want to go back too far to get clean
> > imports.
> > So I decided to take the missing constructor and the two others added
> > by 8223145 and add them to this change, see this diff:
> > http://cr.openjdk.java.net/~goetz/wr19/8223638-replace_wildcard_6-
> > jdk11/02/test/jdk/sun/net/www/httptest/TestHttpServer.java.udiff.html
> >
> > new webrev:
> > http://cr.openjdk.java.net/~goetz/wr19/8223638-replace_wildcard_6-
> > jdk11/02/
> > https://bugs.openjdk.java.net/browse/JDK-8223638
> > http://hg.openjdk.java.net/jdk/jdk/rev/43439afaab4a
> >
> > Best regards,
> > Goetz.
> >
> > > -----Original Message-----
> > > From: Doerr, Martin <martin.doerr at sap.com>
> > > Sent: Freitag, 27. Dezember 2019 15:36
> > > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> > > dev at openjdk.java.net
> > > Subject: RE: [11u] RFR: 8223638: Replace wildcard address with loopback or
> > > local host in tests - part 6
> > >
> > > Hi Götz,
> > >
> > > looks good.
> > >
> > > Best regards,
> > > Martin
> > >
> > >
> > > > -----Original Message-----
> > > > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net>
> > On
> > > > Behalf Of Lindenmaier, Goetz
> > > > Sent: Freitag, 27. Dezember 2019 11:13
> > > > To: jdk-updates-dev at openjdk.java.net
> > > > Subject: [11u] RFR: 8223638: Replace wildcard address with
> > > > loopback or local host in tests - part 6
> > > >
> > > > Hi,
> > > >
> > > > I would like to downport this because a later 11.0.7-oracle change
> > > > Applies clean with this.
> > > > I had to do a simple resolve due to context in UnreferencedSockets.java
> > > >
> > > > http://cr.openjdk.java.net/~goetz/wr19/8223638-replace_wildcard_6-
> > > > jdk11/01/
> > > > https://bugs.openjdk.java.net/browse/JDK-8223638
> > > > http://hg.openjdk.java.net/jdk/jdk/rev/43439afaab4a
> > > >
> > > > Best regards,
> > > > Goetz.
More information about the jdk-updates-dev
mailing list