[11u] RFR: 8236848: [JDK 11u] make run-test-tier1 fails after backport of JDK-8232834

Severin Gehwolf sgehwolf at redhat.com
Thu Jan 9 12:37:30 UTC 2020


On Thu, 2020-01-09 at 12:32 +0000, Lindenmaier, Goetz wrote:
> Hi,
> 
> First sorry for breaking this.
> Looks good to me.

Thanks for the review, Goetz!

Cheers,
Severin

> Best regards,
>   Goetz
> 
> > Am 09.01.2020 um 10:43 schrieb Severin Gehwolf <sgehwolf at redhat.com>:
> > 
> > > On Thu, 2020-01-09 at 10:34 +0100, Mario Torre wrote:
> > > Hi Severin,
> > > 
> > > Good catch, the fix looks good to me.
> > 
> > Thanks for the quick review, Mario! I've added the jdk11u-fix-request
> > label and will push once approved.
> > 
> > Thanks,
> > Severin
> > 
> > > Cheers,
> > > Mario
> > > 
> > > > On Thu, Jan 9, 2020 at 10:31 AM Severin Gehwolf <sgehwolf at redhat.com> wrote:
> > > > Hi,
> > > > 
> > > > Please review this OpenJDK 11.0.7-dev only fix. 'make run-test-*' is
> > > > currently broken after the backport of JDK-8232834. Fails with:
> > > > 
> > > > /usr/bin/bash: -c: line 0: syntax error near unexpected token `)'
> > > > 
> > > > Fix is rather trivial and adjusts the backport to match what's in
> > > > jdk/jdk by removing the extra closing brackets so opening and closing
> > > > brackets are balanced again.
> > > > 
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8236848
> > > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8236848/01/webrev/
> > > > 
> > > > Thoughts?
> > > > 
> > > > Thanks,
> > > > Severin
> > > > 



More information about the jdk-updates-dev mailing list