[11u] Incomplete backport: JDK-8210910

[Langer, Christoph]

Hi Martin,

thanks for fixing this. I have changed the title of your issue to: "Missing files in backport of JDK-8210910" and approved it. Please go ahead and push.

Thanks Aleksey for spotting this. We'll check our setup about why that happened. (e.g. why the files were missed out and why we obviously didn't run the tests that would have spotted this.)

Best regards
Christoph

> -----Original Message-----
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Montag, 20. Januar 2020 14:44
> To: Aleksey Shipilev <shade at redhat.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; Langer, Christoph
> <christoph.langer at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: RE: [11u] Incomplete backport: JDK-8210910
> 
> Hi Aleksey,
> 
> thanks for reporting. I've created an issue:
> https://bugs.openjdk.java.net/browse/JDK-8237540
> 
> @Christoph, can I push the following files from the original change:
> test/jdk/sanity/client/SwingSet/src/resources/images/duke.jpg
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/FileChooserDemo.gif
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/apply.png
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/fliphor.png
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/flipvert.png
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/rotateleft.png
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/filecho
> oser/resources/images/rotateright.png
> 
> Best regards,
> Martin
> 
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Aleksey Shipilev
> > Sent: Montag, 20. Januar 2020 13:55
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Cc: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] Incomplete backport: JDK-8210910
> >
> > Hi Goetz,
> >
> > See:
> >   https://bugs.openjdk.java.net/browse/JDK-8210910
> >
> > Compare:
> >   https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/2b542536582a
> >   https://hg.openjdk.java.net/jdk/jdk/rev/c70468fc7118
> >
> > New files are missing.
> >
> > Because of this, tier3 tests fail:
> >  $ make run-test
> TEST=sanity/client/SwingSet/src/FileChooserDemoTest.java
> >
> > ...with:
> >  java.nio.file.NoSuchFileException:
> > .../jdk-updates-jdk11u-
> > dev/test/jdk/sanity/client/SwingSet/src/resources/images/duke.jpg
> >
> > --
> > Thanks,
> > -Aleksey