[11u] RFR: backport JDK-8247246: Add explicit ResolvedJavaType.link and expose, presence of default methods

Severin Gehwolf sgehwolf at redhat.com
Thu Jul 2 15:28:57 UTC 2020


Hi,

On Wed, 2020-07-01 at 21:09 +0300, Foivos Zakkak wrote:
> Hi Severin,
> 
> Thanks for your review.
> I am attaching a new patch without the copyright updates this time.

Looks good to me.

FWIW, I've uploaded a webrev of this patch here:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8247246/01/webrev/

Thanks,
Severin

> Regards,
> Foivos
> 
> On 01/07/2020 19:27, Severin Gehwolf wrote:
> > Hi Foivos,
> > 
> > On Wed, 2020-07-01 at 15:12 +0300, Foivos Zakkak wrote:
> > > Hello all,
> > > 
> > > I am attaching a backport
> > > https://bugs.openjdk.java.net/browse/JDK-8247246 to jdk11u-dev.
> > For reference, this is the original change in JDK 15:
> > https://hg.openjdk.java.net/jdk/jdk15/rev/b58fc6058055
> > 
> > > This backport fixes https://github.com/oracle/graal/issues/2628
> > > 
> > > The backport applied cleanly except for some minor issues which I
> > > resolved by changing:
> > > 
> > > JVMCI_THROW(NullPointerException);
> > > to
> > > THROW(vmSymbols::java_lang_NullPointerException());
> > > 
> > > and
> > > 
> > > Klass* klass = JVMCIENV->asKlass(jvmci_type);
> > > to
> > > Klass* klass = CompilerToVM::asKlass(jvmci_type);
> > > 
> > > 
> > > The backport has been successfully tested using:
> > > 
> > > make run-test TEST="hotspot/jtreg/compiler/jvmci"
> > > make run-test-tier1
> > > 
> > > I have also successfully built graal master against the patched JDK
> > src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
> > 
> > The original change didn't include a copyright update. So should the
> > backport.
> > 
> > This actually applies to all files touched.
> > 
> > Thanks,
> > Severin
> > 
> > > Thanks,
> > > Foivos Zakkak
> > > 
> > > PS: Pretty happy to submit my first contribution to OpenJDK
> > > 



More information about the jdk-updates-dev mailing list