RFR [jdk11]: 8212200: assert(on_stack()) failed when shared java.lang.object is redefined by JVMTI agent

[Langer, Christoph]

Hi Matthias,

thanks - this looks good to me.

Best regards
Christoph

> -----Original Message-----
> From: Baesken, Matthias <matthias.baesken at sap.com>
> Sent: Mittwoch, 8. Juli 2020 11:11
> To: Langer, Christoph <christoph.langer at sap.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; 'jdk-updates-dev at openjdk.java.net' <jdk-
> updates-dev at openjdk.java.net>
> Subject: RE: RFR [jdk11]: 8212200: assert(on_stack()) failed when shared
> java.lang.object is redefined by JVMTI agent
> 
> Hello here is the updated webrev :
> 
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8212200.2/
> 
> 
> - test is rebroken ( == doesn't include the 2 fixes)
> -comment changes in systemDictionary.hpp  adjusted
> 
> Best regards, Matthias
> 
> 
> 
> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Mittwoch, 8. Juli 2020 09:29
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Baesken, Matthias
> <matthias.baesken at sap.com>; 'jdk-updates-dev at openjdk.java.net' <jdk-
> updates-dev at openjdk.java.net>
> Subject: RE: RFR [jdk11]: 8212200: assert(on_stack()) failed when shared
> java.lang.object is redefined by JVMTI agent
> 
> Hi Matthias,
> 
> can you post an updated webrev of the fix you're going to push for JDK-
> 8212200?
> 
> I assume 8221918 and 8213275  would apply cleanly on top of it, right?
> 
> Cheers
> Christoph
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > Behalf Of Lindenmaier, Goetz
> > Sent: Dienstag, 7. Juli 2020 14:42
> > To: Baesken, Matthias <matthias.baesken at sap.com>; 'jdk-updates-
> > dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
> > Subject: [CAUTION] RE: RFR [jdk11]: 8212200: assert(on_stack()) failed
> when
> > shared java.lang.object is redefined by JVMTI agent
> >
> > Yes, that is fine.  Thank you.
> >
> > Best regards,
> >   Goetz.
> >
> > > -----Original Message-----
> > > From: Baesken, Matthias <matthias.baesken at sap.com>
> > > Sent: Tuesday, July 7, 2020 2:03 PM
> > > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'jdk-updates-
> > > dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
> > > Subject: RE: RFR [jdk11]: 8212200: assert(on_stack()) failed when shared
> > > java.lang.object is redefined by JVMTI agent
> > >
> > > Hi Götz ,
> > >
> > > >For the fixes to the test you included in your change.
> > > >Please downport them as changes of its own, and
> > > >push the three changes together.
> > >
> > > Okay I requested
> > >
> > > https://bugs.openjdk.java.net/browse/JDK-8221918
> > >
> > > and added this review to the comments , hope that's fine with you.
> > >
> > > Best regards, Matthias
> > >
> > >
> > > ( and btw  downporting all 3 as single patches  generates  additional effort
> > +
> > > room for error . )
> > >
> > >
> > > -----Original Message-----
> > > From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > > Sent: Montag, 6. Juli 2020 12:17
> > > To: Baesken, Matthias <matthias.baesken at sap.com>; 'jdk-updates-
> > > dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
> > > Subject: RE: RFR [jdk11]: 8212200: assert(on_stack()) failed when shared
> > > java.lang.object is redefined by JVMTI agent
> > >
> > > Hi Matthias,
> > >
> > > I had a look at your change.
> > >
> > > classFile.cpp:
> > > You skipped one chunk, as the fixed code is not in 11. OK.
> > >
> > > systemDictionary.hpp
> > > You removed comment
> > > " and a flag word
> > > // that makes some minor distinctions, like whether the klass
> > > // is preloaded, optional, release-specific, etc."
> > > I think this should be kept, as this is still relevant in 11.
> > > Your change does not touch this flag.
> > >
> > > Other changes are ok.
> > >
> > > heapShared.cpp
> > > Just indentation, ok.
> > >
> > > For the fixes to the test you included in your change.
> > > Please downport them as changes of its own, and
> > > push the three changes together.
> > >
> > > Best regards,
> > >  Goetz.
> > >
> > > > -----Original Message-----
> > > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > > Behalf
> > > > Of Baesken, Matthias
> > > > Sent: Tuesday, June 30, 2020 9:36 AM
> > > > To: 'jdk-updates-dev at openjdk.java.net' <jdk-updates-
> > > dev at openjdk.java.net>
> > > > Subject: [CAUTION] RFR [jdk11]: 8212200: assert(on_stack()) failed
> when
> > > > shared java.lang.object is redefined by JVMTI agent
> > > >
> > > > Hello, please review  the jdk11 backport of  8212200 .
> > > >
> > > > I had to do a few slight adjustments to adjust the src  changes of
> 8212200
> > > to
> > > > jdk11 .
> > > >
> > > > The test
> > > >
> > > (
> >
> test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/ReplaceCritical
> > > > Classes.java.)  from the original jdk/jdk webrev  of 8212200   did not
> work.
> > > > So I had to include adjustments from 8221918 and 8213275  to fix  the
> test
> > .
> > > >
> > > >
> > > >
> > > > Bug/webrev :
> > > >
> > > > https://bugs.openjdk.java.net/browse/JDK-8212200
> > > >
> > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8212200.0/
> > > >
> > > >
> > > > Original jdk/jdk webrev :
> > > >
> > > > http://hg.openjdk.java.net/jdk/jdk/rev/625f6c742392
> > > >
> > > >
> > > > Thanks, Matthias