8236464: SO_LINGER option is ignored by SSLSocket in JDK 11

[Lindenmaier, Goetz]

Hi Matthias,

Thanks for your review.

The further changes in this function stem from:
8221882: Use fiber-friendly java.util.concurrent.locks in JSSE
8224829: AsyncSSLSocketClose.java has timing issue

Obviously, we don't need fiber preparation in 11.
As I understand, the second issue is a fix for the first.

So I think we should not bring these to 11.

Best regards,
  Goetz.


From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Friday, July 10, 2020 12:46 PM
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'jdk-updates-dev at openjdk.java.net' <jdk-updates-dev at openjdk.java.net>
Subject: Re: 8236464: SO_LINGER option is ignored by SSLSocket in JDK 11


Hello Götz, the patch itself looks good .

However I noticed  that  in   src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java    void closeNotify(boolean useUserCanceled) throws IOException {..}
  there are some  more  diffs   related to  SO_LINGER/linger  when comparing jdk/jdk and jdk11  .
Have you checked those , do we want them in jdk11 too ?


Best regards, Matthias




---------------------------------

Hi,



I am downporting this for parity with 11.0.9-oracle.

I had to do quite some adaptions:

http://cr.openjdk.java.net/~goetz/wr20/8236464-SSLSocket_LINGER-jdk11/01/



src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java

The change renames a method that is not there in 11.

I skipped the renaming and applied the functional change

that is in the same chunk.



src/java.base/share/classes/sun/security/ssl/TransportContext.java

The code deleted differs, because in 15 explicit locking

is used. I added a synchronized block in the method

introduced.



Please review.



https://bugs.openjdk.java.net/browse/JDK-8236464

https://hg.openjdk.java.net/jdk/jdk/rev/c783b60f48db



Best regards,

  Goetz