[11u] RFR: 8249277: TestVerifyIterativeGVN.java is failing with timeout in OpenJDK 11

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Jul 17 09:36:11 UTC 2020


Hi Severin

> If you go down the route of using JDK-8249277, please do
> mention JDK-8248521 via "Summary" in the commit message so it shows up
> when 'log -k'-ing for this change.
Like this?
http://cr.openjdk.java.net/~goetz/wr20/8249277-TestVerifyIterativeGVN_timeout-jdk11/02/

Best regards,
  Goetz.

> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Friday, July 17, 2020 11:06 AM
> To: Langer, Christoph <christoph.langer at sap.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; 'jdk-updates-dev at openjdk.java.net' <jdk-
> updates-dev at openjdk.java.net>
> Cc: Andrew Haley <aph at redhat.com>
> Subject: Re: [11u] RFR: 8249277: TestVerifyIterativeGVN.java is failing with
> timeout in OpenJDK 11
> 
> Hi,
> 
> On Fri, 2020-07-17 at 08:36 +0000, Langer, Christoph wrote:
> > Hi,
> >
> > the change looks good to me, too.
> >
> > I think, however, it should be submitted as backport of
> https://bugs.openjdk.java.net/browse/JDK-8248521. While it is not a literal
> backport of the fix for JDK-8248521, since that one is not available obviously
> (as it was done on Oracle's JDK11 release), it though aims to fix the reported
> problem. Having the fix as JBS backport item of JDK-8249277 will make it
> more obvious that the issue was addressed in OpenJDK, too.
> >
> > @Severin, aph or others, do you have an opinion here?
> 
> Good question. I'd be fine either way. A slight preference being to use
> JDK-8248521 when pushing as it will likely help the filters to track
> parity work. If you go down the route of using JDK-8249277, please do
> mention JDK-8248521 via "Summary" in the commit message so it shows up
> when 'log -k'-ing for this change.
> 
> Thanks,
> Severin
> >
> > > -----Original Message-----
> > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > > Behalf Of Christian Hagedorn
> > > Sent: Donnerstag, 16. Juli 2020 15:31
> > > To: Baesken, Matthias <matthias.baesken at sap.com>; Lindenmaier,
> Goetz
> > > <goetz.lindenmaier at sap.com>; 'jdk-updates-dev at openjdk.java.net'
> <jdk-
> > > updates-dev at openjdk.java.net>
> > > Subject: Re: [11u] RFR: 8249277: TestVerifyIterativeGVN.java is failing
> with
> > > timeout in OpenJDK 11
> > >
> > > Hi Goetz
> > >
> > > Looks good to me!
> > >
> > > Best regards,
> > > Christian
> > >
> > > On 16.07.20 09:42, Baesken, Matthias wrote:
> > > > Hi Götz  thanks for adjusting the timeout . Looks good to me !
> > > >
> > > > Best regards, Matthias
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Lindenmaier, Goetz
> > > > > Sent: Tuesday, July 14, 2020 10:22 AM
> > > > > To: jdk-updates-dev at openjdk.java.net
> > > > > Subject: [11u] RFR: 8249277: TestVerifyIterativeGVN.java is failing
> with
> > > > > timeout in OpenJDK 11
> > > > >
> > > > > Hi
> > > > >
> > > > > This test times out on mac. I would like to increase the timeout.
> > > > > Please review:
> > > > > http://cr.openjdk.java.net/~goetz/wr20/8249277-
> > > > > TestVerifyIterativeGVN_timeout-jdk11/01/
> > > > >
> > > > > Oracle did a similar change in the closed repo:
> > > > >    https://bugs.openjdk.java.net/browse/JDK-8248521
> > > > > but the change is not visible, so I crafted my own.
> > > > >
> > > > > New bug, open 11u only:
> > > > > https://bugs.openjdk.java.net/browse/JDK-8248521
> > > > >
> > > > > Best regards,
> > > > >    Goetz.



More information about the jdk-updates-dev mailing list