[11u] RFR: JDK-8222074: Enhance auto vectorization for x86

[Langer, Christoph]

Hi Paul,

sorry for the delay but I eventually approved the prerequisites JDK-8222074 and JDK-8224234.

Cheers
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Hohensee, Paul
> Sent: Mittwoch, 24. Juni 2020 19:45
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Lemmond, Dan
> <dlemmond at amazon.com>; jdk-updates-dev at openjdk.java.net
> Subject: RE: [11u] RFR: JDK-8222074: Enhance auto vectorization for x86
> 
> The 11.0.8 backport of JDK-8230591 was reverted by JDK-8245649 because it
> required the backport dependencies Dan lists in his email. I'll file a redo JDK-
> 8230591 backport request on Dan's behalf once the prerequisite backports
> are done.
> 
> We would like to backport aarch64 performance work because ARM64-based
> server are being rapidly adopted for high performance floating point
> applications. JDK 11 will be the primary Java execution platform for them for
> some time to come.
> 
> Thanks,
> Paul
> 
> On 6/22/20, 6:15 AM, "jdk-updates-dev on behalf of Lindenmaier, Goetz"
> <jdk-updates-dev-bounces at openjdk.java.net on behalf of
> goetz.lindenmaier at sap.com> wrote:
> 
>     Hi Dan,
> 
>     I had a look at your change.
> 
>     The patch in the webrev is missing the original change
>     comments, please make sure to push it with the correct
>     information.
> 
>     Besides that the downport looks good, omitting the test coding
>     is fine.
> 
>     You are right,
>     "8224234 compiler/codegen/TestCharVect2.java fails in test_mulc"
>     needs to be pushed with this one.  The other follow-up is already
>     downported.
> 
>     Best regards,
>       Goetz
> 
>     -----Original Message-----
>     From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Lemmond, Dan
>     Sent: Samstag, 6. Juni 2020 00:09
>     To: jdk-updates-dev at openjdk.java.net
>     Subject: [DMARC FAILURE] [11u] RFR: JDK-8222074: Enhance auto
> vectorization for x86
> 
>     Hi,
> 
>     I sent this review out previously but it was moderated. Moderators, feel
> free to discard the old one.
> 
>     This backport is a prerequisite for backporting JDK-
> 8230591<https://bugs.openjdk.java.net/browse/JDK-8230591>. I plan to
> backport JDK-8226721<https://bugs.openjdk.java.net/browse/JDK-8226721>
> and JDK-8231713<https://bugs.openjdk.java.net/browse/JDK-8231713> in
> the coming days before finally backporting JDK-8230591.
> 
>     This review is part of a set and will need to be pushed with the backport for
> JDK-8224234<https://bugs.openjdk.java.net/browse/JDK-8224234> which I
> will be sending out shortly.
> 
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8222074
>     Webrev: http://cr.openjdk.java.net/~phh/8222074/webrev.11u.00/
>     Original review thread: https://mail.openjdk.java.net/pipermail/hotspot-
> compiler-dev/2019-May/033561.html
> 
>     Please review this backport for JDK-8222074 to 11u. The changeset applied
> cleanly for the most part, only requiring a manual fix for two hunks.
> 
>     The two hunks that needed to be fixed were hunk 3 in assembler_x86.hpp
> and hunk 3 in x86.ad.
> 
>     The backport compiled without issue and successfully passed the Tier1
> Hotspot tests.
> 
>     Please note that the change to CheckGraalIntrinsics.java was omitted from
> this backport as the check was “isJDK13OrHigher” which is not relevant for
> 11u.
> 
>     Thank you,
>     Dan
>