[11u] RFR 8238284: [macos] Zero VM build fails due to an obvious typo

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jul 22 06:07:59 UTC 2020


Hi Vladimir, 

The change looks good.

If the omitted part would be more complex, I would 
Propose to make a separate change for this, so that 
8238284 is not marked as downported. 
But as the fix (!-->I) is quite obvious, and as the change
introducing this typeo (8234737) is quite unlikely to 
be downported, I am fine with handling this as you 
do.

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On Behalf
> Of Vladimir Kempik
> Sent: Tuesday, July 21, 2020 11:11 PM
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR 8238284: [macos] Zero VM build fails due to an obvious
> typo
> 
> Hello
> Please review this backport of JDK-8238284 to jdk11u
> 
> The patch didn’t apply cleanly. Original 8238284 fixed two issues in jdk15:
> JDK-8237437 - since jdk14
> JDK-8165929 - since jdk11
> 
> Jdk11 only has 8165929 so only part of original fix needs to be backported to
> jdk11, that part applies cleanly.
> 
> This is part2 out of 3 fixes needed to fix zero vm on macos.
> 
> Fix has also part for linux but it wasn’t affected in my testing.
> 
> Risks are low because the patch just adds const keyword to some vars for
> zerovm
> 
> The bug: https://bugs.openjdk.java.net/browse/JDK-8238284
> The webrev: http://cr.openjdk.java.net/~vkempik/8238284/webrev.11u.00/
> Original review https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-
> January/040681.html
> Other two mentioned bugs: https://bugs.openjdk.java.net/browse/JDK-
> 8234737 ,  https://bugs.openjdk.java.net/browse/JDK-8165929
> 
> Thanks, Vladimir


More information about the jdk-updates-dev mailing list