[11u] RFR(XS): 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater()

[Hohensee, Paul]

Lgtm. :)

Thanks,
Paul

On 7/29/20, 6:58 AM, "jdk-updates-dev on behalf of Volker Simonis" <jdk-updates-dev-retn at openjdk.java.net on behalf of volker.simonis at gmail.com> wrote:

    : Hi,

    can I please have a review for the following tiny downport?
    The fix itself itself is trivial and applies cleanly. For the test I
    had to change two lines because of a missing method in jdk11 compared
    to 14.

    Original bug and fix:
    https://bugs.openjdk.java.net/browse/JDK-8234011
    https://hg.openjdk.java.net/jdk/jdk/rev/fe87a92570db

    Complete 11u downport:
    http://cr.openjdk.java.net/~simonis/webrevs/2020/8234011_11u/
    Changes required for 11u downport:
    http://cr.openjdk.java.net/~simonis/webrevs/2020/8234011_11u_changes/

    In jdk 11 we don't have the `FileSystems.newFileSystem(..)` variant
    which takes a `Path` as a first argument so we have to manually
    construct a corresponding URI first.

    Also notice the small change from `Map.of("create", true)` to
    `Map.of("create", "true")` which isn't strictly necessary for OpenJDK
    11u but required for Oracle jdk 11 because they haven't downported
    JDK-8034802 yet (and we want to be nice to our Oracle colleagues just
    in case they want to take this downport as well :)

    Thank you and best regards,
    Volker

    [1] https://bugs.openjdk.java.net/browse/JDK-8034802