[11u] RFR: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

[Severin Gehwolf]

On Fri, 2020-07-31 at 13:01 +0200, Aleksey Shipilev wrote:
> On 7/30/20 10:19 AM, Severin Gehwolf wrote:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8250627
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250627/jdk11/01/webrev/
> > original-change: https://hg.openjdk.java.net/jdk/jdk/rev/c9ad4de69c32
> 
> This looks good to me.

Thanks for the review!

> I have a passing question about the original patch, though. Are we sure only symbols-unix needs to
> be updated? I.e. is JVM_IsUseContainerSupport ever called from Linux binaries, not from anywhere else?

I believe so, yes. The only call site for JVM_IsUseContainerSupport is
in a Linux-only native (also note that container support is a Linux
only feature):

JDK 11u:  http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250627/jdk11/01/webrev/src/java.base/linux/native/libjava/Metrics.c.html
Original: https://hg.openjdk.java.net/jdk/jdk/rev/c9ad4de69c32#l5.37

Thanks,
Severin