[11u] RFA: 8242283: Can't start JVM when java home path includes non-ASCII character

[Yasumasa Suenaga]

Hi all,

I've received email from Naoto (jdk-updates Reviewer), but it wasn't delivered because he hadn't subscribed jdk-update-dev.
I share message from him:

---
I reviewed the following 11u backport of the fix to 8242283, and it looks good to me.

https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-April/003002.html

I cannot reply directly on jdk-updates-dev as I am not subscribing to it.

Naoto
---


Thanks,

Yasumasa


On 2020/04/14 9:40, Yasumasa Suenaga wrote:
> Hi all,
> 
> Please approve this backport:
> 
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8242283
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8242283/11u/webrev.00/
>    original changeset: https://hg.openjdk.java.net/jdk/jdk/rev/5f5876adb88c
> 
> JVM fails to start on Windows with non-ASCII characters in the path if current regional format differs from the system locale.
> We need to convert char* to wchar_t* to support long path, so I used CP_THREAD_ACP in MultiByteToWideChar().
> But we found CP_ACP works nicely rather than CP_THREAD_ACP.
> 
> Using CP_THREAD_ACP was introduced in JDK-8240197 and JDK-8240725, however only JDK-8240197 has been backported to 11u.
> So I want to apply original bug to 11u partially. (it makes the change for HotSpot only)
> 
> 
> Thanks,
> 
> Yasumasa