[13u] RFR: 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

Andrew Brygin abrygin at azul.com
Mon Jun 8 14:56:54 UTC 2020


Hello,

 I would like to backport a fix for 8233197 to jdk13u:

Bug: https://bugs.openjdk.java.net/browse/JDK-8233197
Original change: http://hg.openjdk.java.net/jdk/jdk/rev/127ca611f19b
Webrev: http://cr.openjdk.java.net/~bae/13u/8233197/webrev.00/

 The original change applies cleanly except one chunk in
jfrRecorder.cpp, where the condition in is_cds_dump_requested() should
use old notation "(DumpSharedSpaces || DynamicDumpSharedSpaces)" instead
of "Arguments::is_dumping_archive()", because fix for JDK-8231606 has
not been backported into 13u.

src/hotspot/share/jfr/recorder/jfrRecorder.cpp:

< -  if (Arguments::is_dumping_archive() &&
(JfrOptionSet::startup_recording_options() != NULL)) {
< +  if (Arguments::is_dumping_archive() &&
(JfrOptionSet::start_flight_recording_options() != NULL)) {
---
> -  if ((DumpSharedSpaces || DynamicDumpSharedSpaces) &&
(JfrOptionSet::startup_recording_options() != NULL)) {
> +  if ((DumpSharedSpaces || DynamicDumpSharedSpaces) &&
(JfrOptionSet::start_flight_recording_options() != NULL)) {

 The fix tested on linux x86_64 with tier1 and jdk/jfr tests.

Thanks,
Andrew



More information about the jdk-updates-dev mailing list