[11u] RFR(xs): 8247874: Replacement in VersionProps.java.template not working when --with-vendor-bug-url contains '&'

[Andrew Hughes]

On 19/06/2020 14:41, Severin Gehwolf wrote:
> Hi,
> 
> Could I get a review of this OpenJDK 11 specific patch? This same issue
> has been solved in OpenJDK 13 and better with JDK-8223319[1] which
> seems an unrelated issue to the fix of this bug. Also, I have tried
> applying the JDK 13 patch and it doesn't apply well and would mean some
> form of rewrite. I'm not sure this is worth it in this case.
> 
> For this reason, I propose to only backport the small part of the
> (larger) JDK-8223319 fix which fixes the --with-*vendor-bug-url
> functionality when those URLs contain '&'. Since this will be pushed
> (if accepted) under a separate bug there shouldn't be any confusion.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8247874
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8247874/01/webrev/
> 
> Testing: Manual inspection of generated VersionProps.java and manual
> testing of the crash URL.
> 
> Thoughts?
> 
> Thanks,
> Severin
> 
> [1] Add copyright footer to specs and man pages
>     https://bugs.openjdk.java.net/browse/JDK-8223319
> 

Looks good to me. I picked out the same change when scanning through
JDK-8247874.

I agree there's no reason to backport JDK-8247874. My guess would be
that the issue was discovered while fixing 8247874, so it got bundled in
with it. It could just as well have had its own bug ID and separate
changeset at the time; one does not depend on the other.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222