[13u] RFR: 8229888: (zipfs) Updating an existing zip file does not preserve original permissions

Yuri Nesterenko yan at azul.com
Mon Jun 22 09:04:20 UTC 2020


Looks good to me.

--yan

On 22.06.2020 11:51, Andrew Brygin wrote:
> Hello
> 
>  I would like to backport the fix for JDK-8229888 to jdk13u (13.0.4):
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8229888
> Original changeset: https://hg.openjdk.java.net/jdk/jdk/rev/798c0903fcd0
> Webrev: http://cr.openjdk.java.net/~bae/13u/8229888/webrev.00/
> 
>  The original change does not apply cleanly due to context difference:
> 
> <      private IndexNode getInode(byte[] path) {
> <          return
> inodes.get(IndexNode.keyOf(Objects.requireNonNull(entryLookup.apply(path),
> "path")));
> ---
>>      IndexNode getInode(byte[] path) {
>>          return
> inodes.get(IndexNode.keyOf(Objects.requireNonNull(path, "path")));
> 
>  and it also requires import adjustments in 13u:
> 
>> @@ -43,6 +43,8 @@
>>  import java.nio.file.*;
>>  import java.nio.file.attribute.FileAttribute;
>>  import java.nio.file.attribute.FileTime;
>> +import java.nio.file.attribute.PosixFileAttributes;
>> +import java.nio.file.attribute.PosixFileAttributeView;
>>  import java.nio.file.attribute.UserPrincipalLookupService;
>>  import java.nio.file.spi.FileSystemProvider;
>>  import java.security.AccessController;
> 
>  The backport has been tested with tier1, and newly introduced
> regression test.
> 
> Thanks,
> Andrew
> 



More information about the jdk-updates-dev mailing list