[11u] RFR: 8245832: JDK build make-static-libs should build all JDK libraries

[Severin Gehwolf]

On Fri, 2020-06-19 at 15:28 +0200, Severin Gehwolf wrote:
> On Fri, 2020-06-19 at 09:14 +0200, Severin Gehwolf wrote:
> > Hi Bob,
> > 
> > On Thu, 2020-06-18 at 10:15 -0400, Bob Vandette wrote:
> > > Have you done a Mac and Windows build?
> > 
> > FYI: I've had a colleague of mine build this on Windows and it builds
> > fine there for OpenJDK jdk11u-dev. Looking at the changes below it
> > appears we don't need them because we have JDK-8210459 backported in
> > OpenJDK 11u. I'd expect a similar outcome for Mac.
> 
> I have now confirmation this also builds fine on Mac (as is). To
> summarize: it builds fine with this on Linux, Mac, Windows.

Could I get a review from an jdk-updates project reviewer please?
Webrev is:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8245832/01/webrev/

Thanks,
Severin

> > > > On Jun 18, 2020, at 9:16 AM, Severin Gehwolf <sgehwolf at redhat.com>
> > > > wrote:
> > > > 
> > > > On Thu, 2020-06-18 at 14:47 +0200, Severin Gehwolf wrote:
> > > > > Hi,
> > > > > 
> > > > > Could I please get a review of this OpenJDK 11 backport? It's one
> > > > > of
> > > > > the 11.0.9-oracle parity ones.
> > > > > 
> > > > > The patch from jdk/jdk didn't apply cleanly due to context
> > > > > changes in
> > > > > make/Main.gmk. Namely, USE_WRAPPER=true, removed with JDK-
> > > > > 8245287[1] in
> > > > > head but present in OpenJDK 11 head. Adjusted that bit manually.
> > > > > Other
> > > > > than that, the patch is the same.
> > > > > 
> > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8245832
> > > > 
> > > > Sorry wrong webrev link previously:
> > > > 
> > > > webrev: 
> > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8245832/01/webrev/
> > > > 
> > > > > Testing: Building static-libs-image target comparing
> > > > > before/after[2].
> > > > > Testing graal build with this. Seems fine.
> > > > > 
> > > > > Thoughts?
> > > > > 
> > > > > Thanks,
> > > > > Severin
> > > > > 
> > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8245287
> > > > > [2] 
> > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8245832/01/before_after.txt