[11u] RFR: 8245832: JDK build make-static-libs should build all JDK libraries

Severin Gehwolf sgehwolf at redhat.com
Tue Jun 23 11:48:02 UTC 2020


On Tue, 2020-06-23 at 11:18 +0100, Andrew Haley wrote:
> On 23/06/2020 09:55, Severin Gehwolf wrote:
> > Could I get a review from an jdk-updates project reviewer please?
> > Webrev is:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8245832/01/webrev/
> 
> That's one of the most baffling webrevs I've ever seen. Why all the
> Hg version numbers?

I don't know, sorry. Sometimes webrev.ksh behaves that way. I use
different heads for development which seems to be causing it. Fast-
forward to using skara for OpenJDK 11 and this shouldn't be an issue
anymore (hopefully).

> But if I ignore all that, the intent of the patch, modulo the MacOS
> changes is clear. OK.

Thanks for the review!

Cheers,
Severin



More information about the jdk-updates-dev mailing list