[11u] RFR: 8247350: [aarch64] assert(false) failed: wrong size of mach node

[Lindenmaier, Goetz]

Hi Vladimir, 

Thanks, yes, that makes the code better!
http://cr.openjdk.java.net/~goetz/wr20/8247350-aarch_node_size-jdk11/03/

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Kozlov <vladimir.kozlov at oracle.com>
> Sent: Wednesday, June 24, 2020 6:38 PM
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8247350: [aarch64] assert(false) failed: wrong size of
> mach node
> 
> You also have to adapt output changes to 11u - use _regalloc instead of C-
> >regalloc().
> 
> Vladimir
> 
> On 6/24/20 9:33 AM, Lindenmaier, Goetz wrote:
> > Hi Vladimir,
> >
> > Thanks for pointing me to this, I guess I would have not
> > found that ...
> > New webrev:
> > http://cr.openjdk.java.net/~goetz/wr20/8247350-aarch_node_size-
> jdk11/02/
> >
> > Best regards,
> >    Goetz.
> >
> >> -----Original Message-----
> >> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> >> Behalf Of Vladimir Kozlov
> >> Sent: Wednesday, June 24, 2020 6:18 PM
> >> To: jdk-updates-dev at openjdk.java.net
> >> Subject: Re: [11u] RFR: 8247350: [aarch64] assert(false) failed: wrong size
> of
> >> mach node
> >>
> >> Hi Goetz,
> >>
> >> 11u needs additional fix in macroAssembler_aarch64.cpp:
> >>
> >>     void MacroAssembler::stop(const char* msg) {
> >>       address ip = pc();
> >>       pusha();
> >> !   mov(c_rarg0, (address)msg);
> >> !   mov(c_rarg1, (address)ip);
> >>       mov(c_rarg2, sp);
> >>       mov(c_rarg3, CAST_FROM_FN_PTR(address,
> MacroAssembler::debug64));
> >>       // call(c_rarg3);
> >>       blrt(c_rarg3, 3, 0, 1);
> >>       hlt(0);
> >> --- 2141,2152 ----
> >>     }
> >>
> >>     void MacroAssembler::stop(const char* msg) {
> >>       address ip = pc();
> >>       pusha();
> >> !   movptr(c_rarg0, (uintptr_t)(address)msg);
> >> !   movptr(c_rarg1, (uintptr_t)(address)ip);
> >>       mov(c_rarg2, sp);
> >>       mov(c_rarg3, CAST_FROM_FN_PTR(address,
> MacroAssembler::debug64));
> >>       // call(c_rarg3);
> >>       blrt(c_rarg3, 3, 0, 1);
> >>       hlt(0);
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 6/24/20 9:08 AM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> I would like to downport this for parity with 11.0.9-oracle.
> >>>
> >>> I had to resolve the assert coding in output.cpp:
> >>> http://cr.openjdk.java.net/~goetz/wr20/8247350-aarch_node_size-
> >> jdk11/01/
> >>>
> >>> Please review.
> >>>
> >>> https://bugs.openjdk.java.net/browse/JDK-8247350
> >>> https://hg.openjdk.java.net/jdk/jdk15/rev/1c81917f228b
> >>>
> >>> Best regards,
> >>>     Goetz
> >>>