[CAUTION] [jdk11u] RFR: 8229888: (zipfs) Updating an existing zip file does not preserve original permissions

[Langer, Christoph]

Hi Matthias,

I think this looks good now. In ZipFSPermissionsTest, you should update the Javadoc for method "zip" to have document "@throws Exception" instead of "@throws IOException", though, since this was changed.

Let's wait for the nightly test results and then I'll approve it tomorrow.

Best regards
Christoph

> -----Original Message-----
> From: Baesken, Matthias <matthias.baesken at sap.com>
> Sent: Dienstag, 3. März 2020 14:57
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [CAUTION] [jdk11u] RFR: 8229888: (zipfs) Updating an existing
> zip file does not preserve original permissions
> 
> Thanks, new webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8229888_2_jdk11/
> 
> Best regards, Matthias
> 
> 
> > Hi Matthias,
> >
> > I think I was too quick... it should be:
> >
> > FileSystems.newFileSystem(new URI("jar", zipFile.toUri().toString(), null),
> > env)
> >
> > You'll also have to change throws IOException to throws Exception for the
> zip
> > method, since new URI throws URISyntaxException.
> >
> > Best regards
> > Christoph
> >