RFR [jdk11]: 8226795: compiler/tiered/Level2RecompilationTest.java fails when XX:TieredStopAtLevel=1/2/3 is set

[Langer, Christoph]

Hi,

in that case I'd opt for deferring this patch and try to get some traction on backporting JDK-8225019 first.

Best regards
Christoph

-----Original Message-----
From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com> 
Sent: Freitag, 6. März 2020 10:21
To: Baesken, Matthias <matthias.baesken at sap.com>; jdk-updates-dev at openjdk.java.net
Cc: Langer, Christoph <christoph.langer at sap.com>
Subject: RE: RFR [jdk11]: 8226795: compiler/tiered/Level2RecompilationTest.java fails when XX:TieredStopAtLevel=1/2/3 is set

Hi,

basically, the webrev looks good. 

But it's a pity you must skip the fix to OSRFailureLevel4Test.java.
This test was introduced by "8225019: Update JVMCI" which 
should be downported to 11, too. 
If 8225019 is downported later, we will omit the patch to the test.
Unfortunately, the test fails with current 11. Else I would 
have proposed to downport the whole test.

Maybe we should postpone this and ping once more for 
someone to downport 8225019 first?

Anyways, this is not critical for 11.0.7 as it's only a testbug, 
as you stated before, Matthias.

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Baesken, Matthias
> Sent: Freitag, 6. März 2020 09:48
> To: jdk-updates-dev at openjdk.java.net
> Subject: [CAUTION] RE: RFR [jdk11]: 8226795:
> compiler/tiered/Level2RecompilationTest.java fails when
> XX:TieredStopAtLevel=1/2/3 is set
> 
> Ping, may I get a review please ?
> 
> 
> 
> From: Baesken, Matthias
> Sent: Mittwoch, 4. März 2020 16:01
> To: jdk-updates-dev at openjdk.java.net
> Cc: Langer, Christoph <christoph.langer at sap.com>
> Subject: RFR [jdk11]: 8226795: compiler/tiered/Level2RecompilationTest.java
> fails when XX:TieredStopAtLevel=1/2/3 is set
> 
> Hello, please review  this downport of   8226795:
> compiler/tiered/Level2RecompilationTest.java fails when
> XX:TieredStopAtLevel=1/2/3 is set
> To jdk11 .  I would like to have it in jdk11 too because it is in Oracle JDK11.
> 
> The patch applies mostly,  but  file   OSRFailureLevel4Test.java  is not in jdk11 ,
> and there are changes in the  lines around  the patched lines so manual
> intervention is needed .
> 
> 
> 
> Bug :
> 
> https://bugs.openjdk.java.net/browse/JDK-8226795
> 
> Original webrev  :
> 
> https://hg.openjdk.java.net/jdk/jdk/rev/f1a5d48d0471
> 
> Jdk11 webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8226795_0_jdk11/
> 
> 
> 
> Thanks, Matthias