[11u] RFR(s): 8236921: Add build target to produce a JDK image suitable for a Graal/SVM build

[Langer, Christoph]

Hi there,

seems like we currently have a queue of backports that touch the build system. I suggest we apply them in them in the same order as they have been pushed to head. That would be:

1. JDK-8223678 Add Visual Studio Code workspace generation support (for native code)
2. JDK-8232572 Add hooks for custom output dir in Bundles.gmk
3. JDK-8232748 Build static versions of certain JDK libraries
4. JDK-8235686 Add more custom hooks in Bundles.gmk
5. JDK-8236921 Add build target to produce a JDK image suitable for a Graal/SVM build
and eventually I'm planning to backport
6. JDK-8237192 Generate stripped/public pdbs on Windows for jdk images

Applying them in order will probably help to have the least possible amount of rejects and manual resolves.

I'll go through the proposed patches now in that order and regenerate the patches where necessary. I'll post to the relevant review threads.

Cheers
Christoph


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Andrew Hughes
> Sent: Freitag, 13. März 2020 04:46
> To: Severin Gehwolf <sgehwolf at redhat.com>; jdk-updates-dev <jdk-
> updates-dev at openjdk.java.net>
> Subject: Re: [11u] RFR(s): 8236921: Add build target to produce a JDK image
> suitable for a Graal/SVM build
> 
> On 12/03/2020 15:43, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this OpenJDK 11u port of JDK-8236921?
> > This patch is really only for developer convenience who prefer to build
> > their JDK from source and would like to build svm/graal with the
> > result. It adds a new make target, 'graal-builder-image' which then
> > produces an image in <images>/graal-builder-jdk which can be used to
> > build graal/svm.
> >
> > This patch depends on the static-images libs backport[1]. Note that
> > even with that the JDK 15 patch does not apply cleanly because of some
> > context changes:
> >
> >  * jcov-image target is not in JDK 11
> >  * Copyright dates differ in make/Main.gmk and
> >    make/autoconf/spec.gmk.in.
> >
> > Fixed both manually.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8236921
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> 8236921/jdk11u/01/webrev/
> >
> > Testing: built graal-builder-image target and with the result graal
> > master. Works fine.
> >
> > Thanks,
> > Severin
> >
> > [1] http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-
> March/002740.html
> >     Hopefully to be integrated soon.
> >
> 
> This webrev is a mess, I guess because it's not been applied against
> trunk, but with 8232748 in your local tree as well. I don't see why you
> didn't wait until 8232748 was pushed before creating this.
> 
> The patch itself looks fine, once reordered to match the 14u version
> (not sure why the new file occurs first in the 14u version, but not in
> yours). These are the same contextual issues that occurred with 8232748.
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222