[11u] RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

Langer, Christoph christoph.langer at sap.com
Fri Mar 13 08:43:14 UTC 2020


Hi,

I recreated the webrev after backport of 8189861: Refactor CacheFind.

http://cr.openjdk.java.net/~clanger/webrevs/8223678.11u/

The only difference to the original proposal (http://cr.openjdk.java.net/~simonis/webrevs/2020/8223678/) is that no modification to test/make/TestMakeBase.gmk is necessary any more).

Please review ASAP, as this would be the first push in the series of build system backports.

Thanks
Christoph


> -----Original Message-----
> From: Langer, Christoph
> Sent: Mittwoch, 11. März 2020 10:54
> To: Volker Simonis <volker.simonis at gmail.com>; Andrew Hughes
> <gnu.andrew at redhat.com>
> Cc: build-dev <build-dev at openjdk.java.net>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8223678: Add Visual Studio Code workspace
> generation support (for native code)
> 
> Hi Volker,
> 
> > > Out of interest, is the AssertEquals macro something worth backporting
> > > at some point? Generally, I find its worthwhile if people are going to
> > > be doing the same replacement in multiple backports.
> > >
> >
> > I actually wanted to answer something like "..lets wait until we get
> > another backport requiring this.." but already before answering we
> > already ran into such a case (see my answer to the other thread
> > "8232748: "Build static versions of certain JDK libraries"). The only
> > problem is that "8189861: Refactor CacheFind" which introduced
> > AssertEquals is not a trivial downport.
> >
> > Please let me know what you think?
> 
> I've just proposed the backport of "8189861: Refactor CacheFind". Can you
> rebase your change on that and see if it works?
> 
> Best regards
> Christoph



More information about the jdk-updates-dev mailing list