[11u]: RFR 8235686: Add more custom hooks in Bundles.gmk

Langer, Christoph christoph.langer at sap.com
Fri Mar 13 09:56:55 UTC 2020


Hi Goetz,

thanks for the review.

This is the rebased webrev on 11u-dev after JDK-8223678, JDK-8232572 and JDK-8232748: http://cr.openjdk.java.net/~clanger/webrevs/8235686.11u.1/. The changes are obviously still the same but the context differs.

Will push it in order to 11u-dev (11.0.8).

Cheers
Christoph

> -----Original Message-----
> From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Sent: Donnerstag, 12. März 2020 18:12
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-dev <jdk-
> updates-dev at openjdk.java.net>
> Cc: build-dev <build-dev at openjdk.java.net>
> Subject: RE: [11u]: RFR 8235686: Add more custom hooks in Bundles.gmk
> 
> Hi Christoph,
> 
> The change looks good. Reviewed.
> 
> I think Volker wants to bring the FindFiles/CacheFind change to 11,
> which is in the problematic contexts. But I think we should not
> wait for that, as this is a oracle parity change.  It's trivial to resolve
> anyways.
> 
> As Severin I think it's fine to push this to 11.0.8, after all we
> already have tag 7 in jdk11u, i.e. only two weeks to go.
> 
> Best regards,
>   Goetz
> 
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Langer, Christoph
> > Sent: Thursday, March 12, 2020 11:52 AM
> > To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: [CAUTION] [11u]: RFR 8235686: Add more custom hooks in
> > Bundles.gmk
> >
> > Hi,
> >
> > please help to review this Oracle-11.0.7 parity backport for the build
> system.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8235686
> > Original Change: https://hg.openjdk.java.net/jdk/jdk14/rev/91a3f092682f
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235686.11u/
> >
> > The patch needed some trivial resolves and is preceded by JDK-8232572
> > which was already reviewed and will be pushed before this one.
> >
> > Thanks
> > Christoph



More information about the jdk-updates-dev mailing list