[11u] RFR 8235183: Remove the "HACK CODE" in comment

[Langer, Christoph]

Hi,

> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Freitag, 13. März 2020 11:02
> To: Langer, Christoph <christoph.langer at sap.com>; Reingruber, Richard
> <richard.reingruber at sap.com>; jdk-updates-dev at openjdk.java.net
> Subject: Re: [11u] RFR 8235183: Remove the "HACK CODE" in comment
> 
> Hi,
> 
> On 3/13/20 9:44 AM, Langer, Christoph wrote:
> >> -----Original Message-----
> >> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net>
> On
> >> Behalf Of Andrew Haley
> >> Sent: Freitag, 13. März 2020 10:30
> >> To: Reingruber, Richard <richard.reingruber at sap.com>; jdk-updates-
> >> dev at openjdk.java.net
> >> Subject: Re: [11u] RFR 8235183: Remove the "HACK CODE" in comment
> >>
> >> On 3/12/20 2:51 PM, Reingruber, Richard wrote:
> >>>
> >>> 11u webrev:
> >>>   http://cr.openjdk.java.net/~rrich/webrevs/8235183.jdk11u/webrev.0/
> >>>
> >>> Testing: nightly tests @SAP, i.e. jck and jtreg, also in Xcomp mode with
> >> fastdebug and release
> >>> builds on all platforms.
> >>
> >> This isn't suitable for a backport. It fixes no bugs, and has no
> >> user-visible behaviour.
> >
> > Well, one could certainly see it that way. However, we always tried
> > to backport what we found was backported to the equivalent Oracle
> > release.
> 
> How do you know? Presumably because you have access to Oracle's closed
> source code.

No, we just know that this backport exists: https://bugs.openjdk.java.net/browse/JDK-8238957.

What Oracle effectively did in its closed code doesn't matter - they could have done anything.

> > Shall we change this policy?
> 
> That policy exists because we don't want to have bugs in OpenJDK which
> are fixed in Oracle's releases. There never has been any policy which
> says that the source code should be identical, and that's impossible
> anyway. It never occurred to me that anyone would interpret the policy
> in such a way.

Sure, the main motivation for that policy is to have all bugs fixed in OpenJDK that Oracle chose to fix.
For 11u, though, we have so far effectively backported everything we saw backported to Oracle, no matter if it were comment changes, license header changes etc.
I personally would rather continue with this. But if we chose to stop with that and be more picky about changes that don't affect the binary results, I have no strong emotions. We should just not reject this backport and later on approve others that fall into the same category.

You are the lead maintainer, you can set the rules ��

Cheers
Christoph