[11u] RFR 8235183: Remove the "HACK CODE" in comment
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Fri Mar 13 12:02:05 UTC 2020
Hi,
I asked Richard to work on the changes in the query on the jdk11u
project page. I want to get more people in our team working on this,
as we didn't make the dev close of 11.0.7. So thanks Rich for helping
out!
As this change has no effect whatsoever, it makes no difference
whether it is downported or not. (Obviously Oracle does not want
somebody to read through the code and find hints to hacks ... like
parties that have licensed the code ...)
For the query, we can flag it with openjdk-na.
For people that do their own query, and that wonder
that this is not downported, we can comment that it
is only a comment change and thus needs not be downported.
Well, they must read the bug all to the end up to the comment,
or they'll find out themselves by reading the patch.
But we can as well just push it ... then our code does not
mention hacks either
... but really not a big issue ...
Andrew, please decide and label the bug accordingly.
Best regards,
Goetz.
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Andrew Haley
> Sent: Friday, March 13, 2020 11:06 AM
> To: Baesken, Matthias <matthias.baesken at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR 8235183: Remove the "HACK CODE" in comment
>
> Hi,
>
> On 3/13/20 9:56 AM, Baesken, Matthias wrote:
>
> > in some cases it helps to backport also comment-changes like this ,
> > because it makes backporting follow-up changes easier (less diffs /
> > easier patching). And I estimate that there will be follow ups in
> > the sun/security/ssl code , where backporting is important .
>
> Hmm. Surely we can make that change when we backport the follow
> ups. I don't see how changing comments in this way makes life any
> easier, and it certainly adds more churn to the process.
>
> --
> Andrew Haley (he/him)
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> https://keybase.io/andrewhaley
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the jdk-updates-dev
mailing list