[11u] RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

[Langer, Christoph]

OK, will push it then.

Cheers
Christoph

> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Freitag, 13. März 2020 15:04
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-dev <jdk-
> updates-dev at openjdk.java.net>
> Subject: Re: [11u] RFR: 8223678: Add Visual Studio Code workspace
> generation support (for native code)
> 
> On Fri, 2020-03-13 at 13:55 +0000, Langer, Christoph wrote:
> > I have a last minute update to JDK-8223678, though. By working on a
> > backport of another change (JDK-8237192), I recognized that the
> > function "isTargetOs" does not exist in 11u. So I had to replace 2
> > occurences, one in make/common/MakeBase.gmk and the other in
> > make/vscode/CreateVSCodeProject.gmk with the equivalent construct
> > "ifeq ($(OPENJDK_TARGET_OS), windows)". People would probably have
> > recognized this error only when working on Windows.
> >
> > New webrev:
> http://cr.openjdk.java.net/~clanger/webrevs/8223678.11u.1/
> 
> Good catch! Still good.
> 
> Thanks,
> Severin