[11u] RFR: 8235563: [TESTBUG] appcds/CommandLineFlagComboNegative.java does not handle archive mapping failure

[Calvin Cheung]

Hi Christoph,

On 3/13/20 9:15 AM, Langer, Christoph wrote:
> Hi,
>
> I guess this is the last review for a patch from the Oracle parity list for 11.0.7 that will make it into the release. It's a test only change.
>
> The patch itself applies cleanly but it would result in test failures. I had to include a part from another change: http://hg.openjdk.java.net/jdk/jdk/rev/e34379f2a1c8 (https://bugs.openjdk.java.net/browse/JDK-8204591). That part would remove the test execution for the disabled option -XX:+UseAppCDS, which doesn't fail as expected by the new logic..

The removed lines in your webrev was added for fixing 
https://bugs.openjdk.java.net/browse/JDK-8204563.

Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/50469fb301c4

I guess if you want to backport the fix for this bug as is, you'd need 
to backport JDK-8204563 as well.

thanks,

Calvin

>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8235563
> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/6b8a675f35e1
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235563.11u/
>
> Please review.
>
> Thanks
> Christoph
>