[11u] RFR 8235183: Remove the "HACK CODE" in comment

[Andrew Hughes]

On 13/03/2020 15:27, Andrew Haley wrote:

snip...

> 
> I can't guess why Oracle chose to backport this comment-only change,
> but I believe that 11u is about fixing *significant* bugs, by which I
> mean significant to *users*. Last year Aleksey Shipilev made the point
> (rather forcefully!) that maintainers should still be able to reject
> patches even if Oracle approved them. I suspect that the reason for
> his reasoning was if Oracle decide to jump off a cliff, we shouldn't
> jump with them. That isn't the case here, though: this patch is
> harmless.
> 

I believe I also made the same point, though maybe less forcefully ;)

As a maintainer for 8u, I reserve the right to reject patches,
regardless of whether Oracle backported them or not, and equally I don't
regard "Oracle did it" as sufficient reason alone for a backport. This
is why I have been, and remain, against the idea of auto-approving such
patches, as has been suggested in the past.

Much as some at Oracle may believe it to be the other way around,
OpenJDK is the reference implementation and Oracle's tree is a fork of
this. We should not be slavishly following a private fork, which, by its
very nature, it is impossible to ever match exactly.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222