Help requested, backport 8240629 to 11u + 14u

[Andrew Hughes]

On 17/03/2020 13:22, Robert Stupp wrote:
> Hi,
> 
> backporting JDK-8240629 ("argfiles parsing broken for argfiles with comment cross 4096 bytes chunk") to 11u + 14u is trivial. The original patch from jdk/jdk (Java 15) patch file applies cleanly to current jdk-updates/jdk11u + jdk-updates/jdk14u (no changes to the patch) and tests pass locally.
> 
> https://cr.openjdk.java.net/~shade/8240629/webrev.11u.01/ <https://cr.openjdk.java.net/~shade/8240629/webrev.11u.01/> (Thanks to Aleksey Shipilev for creating it!)
> 
> I could need some help (no JBS acount) to get the patch backported to 11u + 14u.
> 
> Cheers,
> Robert
> 
> References:
> https://hg.openjdk.java.net/jdk/jdk/rev/79371dab85c2 <https://hg.openjdk.java.net/jdk/jdk/rev/79371dab85c2>
> https://bugs.openjdk.java.net/browse/JDK-8240629 <https://bugs.openjdk.java.net/browse/JDK-8240629>
> 
> patch file exported using 'hg export -r 58311:79371dab85c2 --git > 8240629.patch' + imported into my 11u+14u clones via qimport/qpush.
> 
> 
> 
> 11u tests:
> 
> 
> make run-test TEST=tier1
> 
> ==============================
> Test summary
> ==============================
>   TEST                                              TOTAL  PASS  FAIL  ERROR   
>   jtreg:test/hotspot/jtreg:tier1                     1297  1297     0   0   
>   jtreg:test/jdk:tier1                               1860  1860     0    0   
>   jtreg:test/langtools:tier1                         3902  3902     0    0   
>   jtreg:test/nashorn:tier1                              0     0     0    0   
>   jtreg:test/jaxp:tier1                                 0     0     0    0   
> ==============================
> TEST SUCCESS
> 
> make run-test TEST=test/jdk/tools/launcher
> 
> ==============================
> Test summary
> ==============================
>   TEST                                              TOTAL  PASS  FAIL  ERROR   
>   jtreg:test/jdk/tools/launcher                        56    56     0    0   
> ==============================
> TEST SUCCESS
> 
> 
> 
> 
> 14u tests:
> 
> make run-test TEST=tier1
> 
> ==============================
> Test summary
> ==============================
>   TEST                                              TOTAL  PASS  FAIL  ERROR   
>   jtreg:test/hotspot/jtreg:tier1                     1471  1471     0   0   
>   jtreg:test/jdk:tier1                               1899  1899     0    0   
>   jtreg:test/langtools:tier1                         4020  4020     0    0   
>   jtreg:test/nashorn:tier1                              0     0     0    0   
>   jtreg:test/jaxp:tier1                                 0     0     0    0   
> ==============================
> TEST SUCCESS
> 
> make run-test TEST=test/jdk/tools/launcher
> 
> ==============================
> Test summary
> ==============================
>   TEST                                              TOTAL  PASS  FAIL ERROR   
>   jtreg:test/jdk/tools/launcher                        57    57     0     0   
> ==============================
> TEST SUCCESS
> 

Hi Robert,

If the fix backports cleanly, you don't actually need a webrev; just
flagging the bug with the jdk[11,14]u-fix-request labels is sufficient.
I've done this for you now:

https://bugs.openjdk.java.net/browse/JDK-8240629

Incidentally, did you write this fix or just report the issue? I don't
see a Contributed-by field on the changeset to credit you, if it's the
former.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222