RFR: [jdk11] 8225789: Empty method parameter type should generate ClassFormatError

Baesken, Matthias matthias.baesken at sap.com
Thu Mar 19 10:24:23 UTC 2020


Thanks for the review !

Best regards, Matthias

-----Original Message-----
From: Doerr, Martin <martin.doerr at sap.com> 
Sent: Donnerstag, 19. März 2020 11:20
To: Baesken, Matthias <matthias.baesken at sap.com>; jdk-updates-dev at openjdk.java.net
Subject: RE: RFR: [jdk11] 8225789: Empty method parameter type should generate ClassFormatError

Hi Matthias,

looks good to me. Thanks for backporting.

Best regards,
Martin


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Baesken, Matthias
> Sent: Dienstag, 17. März 2020 16:11
> To: jdk-updates-dev at openjdk.java.net
> Subject: RFR: [jdk11] 8225789: Empty method parameter type
> should generate ClassFormatError
> 
> Hello,
>    please review the jdk11 backport of  8225789 .
> Do bring the patch into jdk11  I had to confirm the length check  in
> ClassFileParser::verify_unqualified_name because
> Of changes in the stride (the check itself integrates nicely).
> Additionally the class file version in
> /test/hotspot/jtreg/runtime/classFileParserBug/EmptyUnqName.jasm
> was adjusted to 55.
> 
> Bug/ jdk11 webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8225789
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8225789_jdk11/
> 
> ( jdk/jdk change is : https://hg.openjdk.java.net/jdk/jdk/rev/360f8769d3dc  )
> 
> Thanks, Matthias


More information about the jdk-updates-dev mailing list