[11u]: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images

[Langer, Christoph]

Thanks for the review, Matthias.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Baesken, Matthias
> Sent: Dienstag, 24. März 2020 12:26
> To: jdk-updates-dev at openjdk.java.net
> Subject: [CAUTION] RE: [11u]: RFR: 8237192: Generate stripped/public pdbs
> on Windows for jdk images
> 
> Hello Christoph, the downport looks good to me .
> 
> 
> And btw. , we might consider a 11u-dev  downport of   "isTargetOs" and the
> related "is..."  from Util.gmk   (but  with a separate change ) .
> 
> Best regards, Matthias
> 
> From: Langer, Christoph
> Sent: Freitag, 20. März 2020 15:50
> To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-
> dev at openjdk.java.net>
> Subject: [11u]: RFR: 8237192: Generate stripped/public pdbs on Windows for
> jdk images
> 
> Hi,
> 
> please help to review a backport of JDK-8237192 Generate stripped/public
> pdbs on Windows for jdk images to OpenJDK 11.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8237192
> Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/9b999cf5e13a
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8237192.11u/
> 
> Apart from resolving some copyright year changes, I had to trivially resolve
> some hunks in  make/common/NativeCompilation.gmk,
> make/launcher/Launcher-java.base.gmk and make/scripts/compare.sh. In
> NativeCompilation.gmk, the variable $1_SYMBOLS_DIR of the original change
> had to be replaced with the equivalent $1_OUTPUT_DIR. Furthermore I had
> to replace calls to "isTargetOs" in the makefiles with equivalent constructs
> since that function is not available in 11.
> 
> Thanks
> Christoph