[11u] RFR (S): 8234146: compiler/jsr292/ContinuousCallSiteTargetChange.java times out on SPARC

[Doerr, Martin]

Hi Christoph,

looks good to me, too.

Best regards,
Martin


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Reingruber, Richard
> Sent: Donnerstag, 26. März 2020 22:17
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR (S): 8234146:
> compiler/jsr292/ContinuousCallSiteTargetChange.java times out on SPARC
> 
> Hi Christoph,
> 
> thanks for taking care of this. The fix will help prevent timeouts in the named
> test. Note that this isn't a SPARC only issue. The test can misbehave on all
> platforms. At SAP we had timeouts on ppc, arm and x86_64 too.
> 
>   > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8234146.11u/
> 
> Looks good.
> 
> Thanks,
> Richard. // not a Reviewer and somewhat biased as the author of the original
> fix ;)
> 
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Langer, Christoph
> Sent: Donnerstag, 26. März 2020 15:23
> To: jdk-updates-dev at openjdk.java.net
> Subject: [CAUTION] [11u] RFR (S): 8234146:
> compiler/jsr292/ContinuousCallSiteTargetChange.java times out on SPARC
> 
> Hi,
> 
> please review the 11u backport of a test change for a test that can timeout
> under heavy system load.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234146
> Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/ecc59c31cb10
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8234146.11u/
> 
> The patch did not apply to 11u, but adapting was trivial. The change to the
> exclusion list was skipped because the test wasn't excluded in 11u. For the
> test itself, I had to trivially resolve the run directives because the timeout
> option didn't exist upstream.
> 
> Thanks
> Christoph