FW: RFR [jdk11]: 8224847: gc/stress/TestReclaimStringsLeaksMemory.java fails with reserved greater than expected

[Baesken, Matthias]

Thanks !

May I consider this is a review for pushing it to jdk11u-dev  ?

(11u-fix-yes labeling  for  https://bugs.openjdk.java.net/browse/JDK-8224847  is of course also still needed  )

Best regards, Matthias


From: coleen.phillimore at oracle.com <coleen.phillimore at oracle.com>
Sent: Mittwoch, 13. Mai 2020 14:22
To: Baesken, Matthias <matthias.baesken at sap.com>
Subject: Re: FW: RFR [jdk11]: 8224847: gc/stress/TestReclaimStringsLeaksMemory.java fails with reserved greater than expected

I thought I already reviewed this.

Yeah JDK 11 has the old symbol table that I think doesn't require being triggered.  I see JDK 11 already has this.

bool SafepointSynchronize::is_cleanup_needed() {
  // Need a safepoint if there are many monitors to deflate.
  if (ObjectSynchronizer::is_cleanup_needed()) return true;
  // Need a safepoint if some inline cache buffers is non-empty
  if (!InlineCacheBuffer::is_empty()) return true;
  if (StringTable::needs_rehashing()) return true;
  if (SymbolTable::needs_rehashing()) return true;
  return false;
}

So yes, this is good to go.

thanks,
Coleen
On 5/13/20 6:58 AM, Baesken, Matthias wrote:
Hi , I forgot to add you on CC ...

Best regards, Matthias

From: Baesken, Matthias
Sent: Mittwoch, 13. Mai 2020 12:57
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Subject: RFR [jdk11]: 8224847: gc/stress/TestReclaimStringsLeaksMemory.java fails with reserved greater than expected

Hello, please review the jdk11 backport of  8224847: gc/stress/TestReclaimStringsLeaksMemory.java fails with reserved greater than expected .

The jdk11 version differs a little bit from jdk/jdk :

-symbolTable.cpp  is different in 11, so the patch does not really fit there
-stringTable.cpp  uses defines instead of consts in 11 ( around line 60 )





Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8224847

http://cr.openjdk.java.net/~mbaesken/webrevs/8224847_0_jdk11/


Original  jdk/jdk webrev :

http://hg.openjdk.java.net/jdk/jdk/rev/d9a157f6fd71

Thanks, Matthias