RFR [jdk11]: 8234779: Provide idiom for declaring classes noncopyable

Baesken, Matthias matthias.baesken at sap.com
Thu May 14 10:07:52 UTC 2020


Thanks for  the review !

Best regards, Matthias

>Hi Matthias,
>
>Change looks good to me.
>Basically, you omitted a row of chunks not applicable to 11.
>This is fine, obviously.
>
>Best regards,
>  Goetz.


From: Baesken, Matthias
Sent: Dienstag, 12. Mai 2020 09:57
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Subject: RFR [jdk11]: 8234779: Provide idiom for declaring classes noncopyable

Hello, please review the jdk11 backport  of  8234779 .
It adds a lot of usages of the  NONCOPYABLE   macro to jdk11  (however not all places of the jdk/jdk patch are applicable in 11) .

(the macro itself  came in  already  with  the backport of 8234691  where it was needed  : http://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/c62a83c0d865  )

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8234779

http://cr.openjdk.java.net/~mbaesken/webrevs/8234779_0_jdk11/

The jdk/jdk webrev :

https://hg.openjdk.java.net/jdk/jdk/rev/68f9bbda438d


Thanks, Matthias


More information about the jdk-updates-dev mailing list