FW: [11u] RFR/A: 8022574: remove HaltNode code after uncommon trap calls

[Hohensee, Paul]

My bad. New webrev:

http://cr.openjdk.java.net/~phh/8022574/webrev.11u.01/

Thanks,
Paul

On 5/25/20, 7:02 AM, "Volker Simonis" <volker.simonis at gmail.com> wrote:

    On Sun, May 24, 2020 at 12:41 AM Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Original bug: https://bugs.openjdk.java.net/browse/JDK-8022574
    > Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/08fda454c3df
    > Webrev: http://cr.openjdk.java.net/~phh/8022574/webrev.11u.00/
    >
    > This is the last in a series of three of which the first two are
    >
    > https://bugs.openjdk.java.net/browse/JDK-8225653
    > https://bugs.openjdk.java.net/browse/JDK-8231720
    >
    > These apply cleanly and have been tagged jdk11u-fix-request.
    >
    > The backport patch for JDK-8022574 (this review request) is clean except for the hunk that applies to arm.ad. That hunk had to be slightly modified to account for the fact that Oracle’s arm64 port has not been removed from 11u.
    >

    In general, I think the down-port with the small adaption  to arm,.ad
    is fine. However, the 11u webrev you've posted seems to contain the
    merged changes of JDK-8225653, 8231720 and JDK-8022574 which makes it
    a little hard to review. You should be able to do a webrev of only
    JDK-8022574 by passing the "-r <rev>" flag to webrev (in this specific
    case "-r 53211").

    Thank you and best regards,
    Volker

    > Once/if approved, all three backports will be pushed at once.
    >
    > Thanks,
    > Paul
    >