[13u] RFR: 8225797: OldObjectSample event creates unexpected amount of checkpoint data

Yuri Nesterenko yan at azul.com
Fri May 29 10:13:56 UTC 2020


OK, looks fine, thank you!

--yan

On 29.05.2020 13:02, Andrew Brygin wrote:
> Hello,
> 
>  I would like to backport the fix for 8225797 to 13u. It is already in 11u.
> 
>  Bug: https://bugs.openjdk.java.net/browse/JDK-8225797
>  Original change: https://hg.openjdk.java.net/jdk/jdk/rev/caa25ab47aca
>  Webrev: http://cr.openjdk.java.net/~bae/13u/8225797/webrev.00/
> 
>  Prerequisite: JDK-8230398, applies cleanly to 13u.
> 
>  With the fix for JDK-8230398, this change apples to 14u cleanly with
> two little exceptions:
>  the directive '#include "oops/markWord.hpp"' is missed in files
> src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp and
> src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp due to
> absence of fix for JDK-8230398 in 13u, so two changes listed below are
> not applicable to 13u codebase:
> 
> src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp:
> --- pathToGcRootsOperation.cpp
> +++ pathToGcRootsOperation.cpp
> @@ -43,7 +43,6 @@
>  #include "jfr/leakprofiler/utilities/granularTimer.hpp"
>  #include "logging/log.hpp"
>  #include "memory/universe.hpp"
> -#include "oops/markWord.hpp"
>  #include "oops/oop.inline.hpp"
>  #include "runtime/safepoint.hpp"
>  #include "utilities/globalDefinitions.hpp"
> 
> src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp:
> --- rootResolver.cpp
> +++ rootResolver.cpp
> @@ -32,7 +32,6 @@
>  #include "memory/iterator.hpp"
>  #include "memory/universe.hpp"
>  #include "oops/klass.hpp"
> -#include "oops/markWord.hpp"
>  #include "oops/oop.hpp"
>  #include "prims/jvmtiThreadState.hpp"
>  #include "runtime/frame.inline.hpp"
> 
> The rest of the fix applies cleanly.
> 
> Testing: tier1 and jdk/jfr tests pass fine with the change.
> 
> Thanks,
> Andrew
> 



More information about the jdk-updates-dev mailing list