[11u] RFR: 8256483: [TESTBUG] serviceability/jvmti/GetClassMethods/libOverpassMethods.c fails to compile on gcc 4.4.x

[Severin Gehwolf]

Hi,

Please review this build fix for test-image on gcc 4.4.x systems. JDK-
8216324 is included with 11.0.10+1 and has an initial declaration in
the for loop. The fix is trivial and makes the build proceed further.
Another issue relating to JDK-8249821 is still ongoing. This breaks our
vanilla OpenJDK 11 builds. This isn't really suitable for jdk/jdk as
it's moved on to later toolchains. JDK 11.0.9 built fine with gcc
4.4.x, though, so I'd like to fix it in 11.


Bug: https://bugs.openjdk.java.net/browse/JDK-8256483

Proposed fix:

diff --git a/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMethods.c b/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMethods.c
--- a/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMethods.c
+++ b/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMethods.c
@@ -95,7 +95,8 @@
     return NULL;
   }
 
-  for (int i = 0; i < method_count; i++) {
+  int i;
+  for (i = 0; i < method_count; i++) {
     jint modifiers = 0;
     err = JNI_ENV_PTR(jvmti)->GetMethodModifiers(JNI_ENV_ARG2(jvmti, methods[i], &modifiers));
     if (err != JVMTI_ERROR_NONE) {


Testing: Build of test-image target proceeds with it in place.

Thoughts?

Thanks,
Severin