[11u] RFR: 8256483: [TESTBUG] serviceability/jvmti/GetClassMethods/libOverpassMethods.c fails to compile on gcc 4.4.x

[Lindenmaier, Goetz]

Hi Severin,  

Thanks for fixing this. Looks good.

Could you please check that the other two changes out for 
review compile with your toolchain?
They also bring new C code I converted from C++.

[11u] RFR: 8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators
http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-November/004117.html
and 
[11u] RFR: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-November/004162.html

Best regards,
  Goetz.


> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Wednesday, November 18, 2020 11:25 AM
> To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Subject: [11u] RFR: 8256483: [TESTBUG]
> serviceability/jvmti/GetClassMethods/libOverpassMethods.c fails to compile
> on gcc 4.4.x
> 
> Hi,
> 
> Please review this build fix for test-image on gcc 4.4.x systems. JDK-
> 8216324 is included with 11.0.10+1 and has an initial declaration in
> the for loop. The fix is trivial and makes the build proceed further.
> Another issue relating to JDK-8249821 is still ongoing. This breaks our
> vanilla OpenJDK 11 builds. This isn't really suitable for jdk/jdk as
> it's moved on to later toolchains. JDK 11.0.9 built fine with gcc
> 4.4.x, though, so I'd like to fix it in 11.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8256483
> 
> Proposed fix:
> 
> diff --git
> a/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMeth
> ods.c
> b/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMeth
> ods.c
> ---
> a/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMeth
> ods.c
> +++
> b/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMeth
> ods.c
> @@ -95,7 +95,8 @@
>      return NULL;
>    }
> 
> -  for (int i = 0; i < method_count; i++) {
> +  int i;
> +  for (i = 0; i < method_count; i++) {
>      jint modifiers = 0;
>      err = JNI_ENV_PTR(jvmti)->GetMethodModifiers(JNI_ENV_ARG2(jvmti,
> methods[i], &modifiers));
>      if (err != JVMTI_ERROR_NONE) {
> 
> 
> Testing: Build of test-image target proceeds with it in place.
> 
> Thoughts?
> 
> Thanks,
> Severin