[11u] RFR: 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

[Doerr, Martin]

Hi Götz,

thanks for following Richard's proposal. Looks good to me, too.

Best regards,
Martin


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Reingruber, Richard
> Sent: Donnerstag, 26. November 2020 15:10
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8222072: JVMTI GenerateEvents() sends
> CompiledMethodLoad events to wrong jvmtiEnv
> 
> Thanks Götz, looks good to me.
> 
> Cheers, Richard.
> // Note: for some reason I'm not even listed as author in the JDK-updates
> project
> 
> -----Original Message-----
> From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Sent: Donnerstag, 26. November 2020 09:51
> To: Reingruber, Richard <richard.reingruber at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8222072: JVMTI GenerateEvents() sends
> CompiledMethodLoad events to wrong jvmtiEnv
> 
> Hi Richard,
> 
> > I'd suggest to replace true/false with JNI_TRUE/JNI_FALSE and change the
> > type of fail_status to jboolean.
> That makes complete sense.
> http://cr.openjdk.java.net/~goetz/wr20/8222072-wrong_jvmtiEnv-jdk11/02/
> 
> Best,
>   Goetz.
> 
> 
> > -----Original Message-----
> > From: Reingruber, Richard <richard.reingruber at sap.com>
> > Sent: Tuesday, November 24, 2020 4:24 PM
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> > dev at openjdk.java.net
> > Subject: RE: [11u] RFR: 8222072: JVMTI GenerateEvents() sends
> > CompiledMethodLoad events to wrong jvmtiEnv
> >
> > Hi Götz,
> >
> > > The change applies clean, but I had to convert the test coding
> > > from C++ to C.
> >
> > I'd suggest to replace true/false with JNI_TRUE/JNI_FALSE and change the
> > type of
> > fail_status to jboolean.
> >
> > Cheers, Richard.
> >
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf
> > Of Lindenmaier, Goetz
> > Sent: Dienstag, 24. November 2020 08:42
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8222072: JVMTI GenerateEvents() sends
> > CompiledMethodLoad events to wrong jvmtiEnv
> >
> > Hi,
> >
> > I would like to downport this fix for jvmti.
> > Some of the coding added here is needed by follow-up
> > 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving
> > NULL _value"
> > which I downported for 11.0.10-oracle parity.
> >
> > The change applies clean, but I had to convert the test coding
> > from C++ to C.
> >
> > http://cr.openjdk.java.net/~goetz/wr20/8222072-wrong_jvmtiEnv-
> jdk11/01/
> >
> > Please review.
> >
> > https://bugs.openjdk.java.net/browse/JDK-8222072
> > http://hg.openjdk.java.net/jdk/jdk/rev/96230a5ef2ec
> >
> > Best regards
> >   Goetz.