[11u] RFR: 8216324: GetClassMethods is confused by the presence of default methods in super interfaces

[Lindenmaier, Goetz]

Hi Martin, 

Thanks for reviewing again.

Best regards,
  Goetz.

> -----Original Message-----
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Wednesday, October 7, 2020 11:07 AM
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8216324: GetClassMethods is confused by the
> presence of default methods in super interfaces
> 
> Hi Götz,
> 
> ah, these builds require the older C standard. Your fix is fine.
> 
> Best regards,
> Martin
> 
> 
> > -----Original Message-----
> > From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Sent: Mittwoch, 7. Oktober 2020 09:36
> > To: Doerr, Martin <martin.doerr at sap.com>; jdk-updates-
> > dev at openjdk.java.net
> > Subject: RE: [11u] RFR: 8216324: GetClassMethods is confused by the
> > presence of default methods in super interfaces
> >
> > Hi Martin,
> >
> > Thanks for reviewing.
> >
> > Unfortunately, the windows and solaris builds boiled up an issue in the test
> > C-file:
> > ---
> > a/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMet
> > hods.c
> > +++
> > b/test/hotspot/jtreg/serviceability/jvmti/GetClassMethods/libOverpassMet
> > hods.c
> > @@ -61,7 +61,9 @@
> >
> >    if (options != NULL && strcmp(options,
> "maintain_original_method_order")
> > == 0) {
> >      printf("Enabled capability: maintain_original_method_order\n");
> > -    jvmtiCapabilities caps = {};
> > +    jvmtiCapabilities caps;
> > +    memset(&caps, 0, sizeof(jvmtiCapabilities));
> > +
> >      caps.can_maintain_original_method_order = 1;
> >
> >      jvmtiError err = JNI_ENV_PTR(jvmti)-
> > >AddCapabilities(JNI_ENV_ARG(jvmti, &caps));
> >
> > New webrev:
> > http://cr.openjdk.java.net/~goetz/wr20/8216324-
> > GetClassMethods_confused-jdk11/02/
> >
> > Best regards,
> >   Goetz.
> >
> >
> >
> > > -----Original Message-----
> > > From: Doerr, Martin <martin.doerr at sap.com>
> > > Sent: Tuesday, October 6, 2020 12:19 PM
> > > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> > > dev at openjdk.java.net
> > > Subject: RE: [11u] RFR: 8216324: GetClassMethods is confused by the
> > > presence of default methods in super interfaces
> > >
> > > Hi Götz,
> > >
> > > thanks for doing this work. Backport looks good.
> > >
> > > Best regards,
> > > Martin
> > >
> > >
> > > > -----Original Message-----
> > > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > > > Behalf Of Lindenmaier, Goetz
> > > > Sent: Dienstag, 6. Oktober 2020 10:53
> > > > To: jdk-updates-dev at openjdk.java.net
> > > > Subject: [11u] RFR: 8216324: GetClassMethods is confused by the
> > > > presence of default methods in super interfaces
> > > >
> > > > Hi,
> > > >
> > > > I am downporting this for 11.0.10-oracle parity.
> > > > http://cr.openjdk.java.net/~goetz/wr20/8216324-
> > > > GetClassMethods_confused-jdk11/01/
> > > >
> > > > I had to resolve the test library files. In 11, these are C, in the source
> > > > they are C++.
> > > >
> > > > Please review.
> > > > https://bugs.openjdk.java.net/browse/JDK-8216324
> > > > https://hg.openjdk.java.net/jdk/jdk/rev/c379dc750a02
> > > >
> > > > Best regards,
> > > >   Goetz.