[15u] RFR 8254166: Zero: return-type warning in zeroInterpreter_zero.cpp

Severin Gehwolf sgehwolf at redhat.com
Mon Oct 12 15:15:43 UTC 2020


On Mon, 2020-10-12 at 13:08 +0200, Aleksey Shipilev wrote:
> Original fix;
>    https://bugs.openjdk.java.net/browse/JDK-8254166
>    https://git.openjdk.java.net/jdk/commit/7952c06b
> 
> cppInterpreter_zero.cpp was renamed to zeroInterpreter_zero.cpp by JDK-8239782.
> 
> So, 15u patch is:
> 
> diff -r 7b781c30206d src/hotspot/cpu/zero/cppInterpreter_zero.cpp
> --- a/src/hotspot/cpu/zero/cppInterpreter_zero.cpp      Thu Oct 08 09:33:42 2020 +0000
> +++ b/src/hotspot/cpu/zero/cppInterpreter_zero.cpp      Mon Oct 12 09:20:58 2020 +0200
> @@ -99,7 +99,9 @@
>       case T_DOUBLE:
>       case T_VOID:
>         return result;
> -    default  : ShouldNotReachHere();
> +    default:
> +      ShouldNotReachHere();
> +      return result; // silence compiler warnings
>     }
>   }
> 
> (I am going to use this later for backports to 11u and 8u).
> 
> Testing: tier{1,2}, Linux x86_64 Zero bootcycle-images

Zero only change. Looks fine to me.

Thanks,
Severin



More information about the jdk-updates-dev mailing list