[11u] RFR 6722928: Provide a default native GSS-API library on Windows

[Severin Gehwolf]

Hi Martin,

On Wed, 2020-10-21 at 18:08 -0300, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the 11u backport of "6722928: Provide a
> default native GSS-API library on Windows" [1].
> 
> Webrev.00
> 
>  * http://cr.openjdk.java.net/~mbalao/webrevs/6722928/6722928.webrev.11u.00
> 
> Conflicts:
> 
>  *
> src/java.security.jgss/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
>   * There is one hunk that does not apply cleanly because a line below
> the one modified is changed by 8209416 [2].
>    * 8209416 does not apply cleanly (8+ conflicts) and is not
> fundamental to 6722928 as it's an enhancement related to obtaining
> values from properties, while 6722928 is about using the native Windows
> libraries for GSS.
>   * This conflict has been solved by changing the hunk context to match
> 11u source code; there are no changes on the modified line itself.

Good call. Backporting JDK-8209416 for the patch to apply cleanly
doesn't make sense.

The backport looks fine to me.

> Testing:
> 
>  * The main line patch does not include a regression test because of its
> complexity (an Active Directory is needed). I manually tested a few
> calls through the DLL bridge and observed no errors. Given that this is
> a pluggable provider, the risk is low.
> 
> If this proposal is review-approved, I'll go through the CSR process and
> request a 11u backport.

Please go ahead and file the 11 CSR request.

> Followup bugs that will be proposed for 11u backporting:
> 
>  * https://bugs.openjdk.java.net/browse/JDK-8225687

Yes, please. We should get them both integrated to 11 at the same time.

Thanks,
Severin

> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-6722928
> [2] - https://bugs.openjdk.java.net/browse/JDK-8209416
>