[jdk13u-dev] RFR: 8255468: JDK-8255269 incorrectly replaced average copy time

John Cuthbertson johnc at azul.com
Tue Oct 27 17:52:29 UTC 2020


Hi Paul,

Looks good to me. I got to the original review this morning and was going to say something until I saw your followup.

JohnC

> On Oct 27, 2020, at 9:55 AM, Paul Hohensee <phh at openjdk.java.net> wrote:
> 
> Please review this fix to the patch for JDK-8255269. Part of the average copy time calculation was left out. This line from the patch
> 
> double average_copy_time = average_time_ms(G1GCPhaseTimes::ObjCopy);
> 
> should be
> 
> double average_copy_time = average_time_ms(G1GCPhaseTimes::ObjCopy) + average_time_ms(G1GCPhaseTimes::OptObjCopy);
> 
> Thanks,
> Paul
> 
> -------------
> 
> Commit messages:
> - 8255468: JDK-8255269 incorrectly replaced average copy time
> 
> Changes: https://git.openjdk.java.net/jdk13u-dev/pull/6/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=6&range=00
>  Issue: https://bugs.openjdk.java.net/browse/JDK-8255468
>  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
>  Patch: https://git.openjdk.java.net/jdk13u-dev/pull/6.diff
>  Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/6/head:pull/6
> 
> PR: https://git.openjdk.java.net/jdk13u-dev/pull/6



More information about the jdk-updates-dev mailing list