[11u] RFR (S): 8151678: com/sun/jndi/ldap/LdapTimeoutTest.java failed due to timeout on DeadServerNoTimeoutTest is incorrect

Severin Gehwolf sgehwolf at redhat.com
Tue Sep 1 08:06:20 UTC 2020


On Mon, 2020-08-31 at 17:32 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> > I had a look at this for 11u approval and this jumped out at me:
> > 
> > src/jdk.naming.ldap/share/classes/com/sun/jndi/ldap/dns/LdapDnsProvider
> > Service.java
> > 
> >  107         synchronized (LOCK) {
> >  108             Iterator<LdapDnsProvider> iterator = providers.iterator();
> >  109             while (result == null && iterator.hasNext()) {
> >  110                 result = iterator.next().lookupEndpoints(url, envCopy)
> >  111                         .filter(r -> r.getEndpoints().isEmpty())
> >  112                         .orElse(null);
> >  113             }
> > 
> > Line 111 inverses the filter from the original change[1]. This looks
> > wrong.
> 
> Oops, you're right. I believe the nightlies would have shown this regression, but anyway, thanks for spotting it.
> 
> Here's the fix: http://cr.openjdk.java.net/~clanger/webrevs/8151678.11u.2/

Looks good!

Cheers,
Severin



More information about the jdk-updates-dev mailing list