[11u] RFR 8251118: BiasedLocking::preserve_marks should not have a HandleMark

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Sep 2 09:48:05 UTC 2020


Hi Aleksey, 

Looks good.

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On Behalf
> Of Aleksey Shipilev
> Sent: Tuesday, September 1, 2020 11:51 AM
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR 8251118: BiasedLocking::preserve_marks should not have
> a HandleMark
> 
> Original bug:
>    https://bugs.openjdk.java.net/browse/JDK-8251118
>    https://hg.openjdk.java.net/jdk/jdk/rev/abb125b87e74
> 
> This is a follow-up for JDK-8249192. The change is trivial, but it needs some
> adjustments in the
> test code: the test package was not introduced yet, so "gc." needs to be
> dropped.
> 
> 11u patch:
> 
> diff -r db0da07618e0 src/hotspot/share/runtime/biasedLocking.cpp
> --- a/src/hotspot/share/runtime/biasedLocking.cpp       Thu Jul 23 21:10:52
> 2020 +0200
> +++ b/src/hotspot/share/runtime/biasedLocking.cpp       Tue Sep 01 11:50:02
> 2020 +0200
> @@ -800,3 +800,2 @@
>     ResourceMark rm(cur);
> -  HandleMark hm(cur);
> 
> diff -r db0da07618e0 src/hotspot/share/runtime/vframe.hpp
> --- a/src/hotspot/share/runtime/vframe.hpp      Thu Jul 23 21:10:52 2020
> +0200
> +++ b/src/hotspot/share/runtime/vframe.hpp      Tue Sep 01 11:50:02 2020
> +0200
> @@ -32,3 +32,3 @@
>   #include "runtime/frame.hpp"
> -#include "runtime/handles.inline.hpp"
> +#include "runtime/handles.hpp"
>   #include "runtime/stackValue.hpp"
> diff -r db0da07618e0 test/hotspot/jtreg/gc/TestFullGCALot.java
> --- a/test/hotspot/jtreg/gc/TestFullGCALot.java Thu Jul 23 21:10:52 2020
> +0200
> +++ b/test/hotspot/jtreg/gc/TestFullGCALot.java Tue Sep 01 11:50:02 2020
> +0200
> @@ -26,3 +26,3 @@
>    * @key gc
> - * @bug 4187687 8187819
> + * @bug 4187687 8187819 8251118
>    * @summary Ensure no access violation when using FullGCALot
> @@ -30,2 +30,3 @@
>    * @run main/othervm -XX:NewSize=10m -XX:+FullGCALot -
> XX:FullGCALotInterval=120 TestFullGCALot
> + * @run main/othervm -XX:NewSize=10m -XX:+FullGCALot -
> XX:FullGCALotInterval=120
> -XX:+UseBiasedLocking TestFullGCALot
>    */
> 
> Testing: tier{1,2,3} with and without Shenandoah; affected test
> 
> --
> Thanks,
> -Aleksey



More information about the jdk-updates-dev mailing list